Agent Builder #1291
Open
Agent Builder #1291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| customResourceProvider, | ||
| dockerImageAsset.imageUri | ||
| ); | ||
| const agentCoreRuntimeRole = this.createAgentCoreRuntimeRole(); |
There was a problem hiding this comment.
私の環境依存かもしれませんが、以下のエラーが発生していました。；
AgentCoreStack: creating CloudFormation changeset...
10:35:07 | CREATE_FAILED | AWS::BedrockAgentCore::Runtime | GenericAgentCoreGe...eRuntimeL1B2F7F803
Resource handler returned message: "Invalid request provided: Access denied while validating ECR URI 'xxxx.dkr.ecr.us-east-1.amazonaws.com/c
dk-hnb659fds-container-assets-xxxxx-us-east-1:93a0bc6401c8848c3174de19d2010ba5897f4c44ebd6dd72ac3d3b9364165d52'. The execution role requires
permissions for ecr:GetAuthorizationToken, ecr:BatchGetImage, and ecr:GetDownloadUrlForLayer operations. (Service: BedrockAgentCoreControl, Status C
ode: 400, Request ID: b4d1d923-6c79-47b4-afd5-fe87c4a7fa98) (SDK Attempt Count: 1)" (RequestToken: edb004fc-9aa1-c040-b839-a4707f45513d, HandlerErro
rCode: InvalidRequest)grantPull をつけて解消させました。vibe 解決させたのでもう少し良い改善方法があるかもしれませんが取り急ぎ共有です。
Suggested change
| const agentCoreRuntimeRole = this.createAgentCoreRuntimeRole(); | |
| const agentCoreRuntimeRole = this.createAgentCoreRuntimeRole(); | |
| dockerImageAsset.repository.grantPull(agentCoreRuntimeRole); |
tbrand
reviewed
Oct 23, 2025
| } from '@aws-sdk/client-cognito-identity-provider'; | ||
|
|
||
| // Initialize Cognito client | ||
| const cognitoClient = new CognitoIdentityProviderClient({}); |
There was a problem hiding this comment.
これ閉域だと endpoint 指定しないとバグる気がする。
https://github.com/aws-samples/generative-ai-use-cases/pull/1252/files
対応わからなければ後で自分が修正するので、そのままでも良いです。
| new LambdaIntegration(agentBuilderFunction), | ||
| commonAuthorizerProps | ||
| ); | ||
| } |
There was a problem hiding this comment.
これ construct 分離したほうが良いかもしれないです。
tbrand
reviewed
Oct 23, 2025
|
|
||
| // Deploy runtimes based on flags | ||
| this.deployGenericRuntime(); | ||
| this.deployAgentBuilderRuntime(); |
There was a problem hiding this comment.
これって正しいですか？フラグのどちらかが true の場合に両方の runtime を作っているように見える。
| "flows": [], | ||
| "agentBuilderEnabled": false, | ||
| "createGenericAgentCoreRuntime": false, | ||
| "agentCoreExternalRuntimes": [], |
There was a problem hiding this comment.
今回の対応関係ないですが、agentCoreRegion が抜けているかもしれないです！
ついでに入れてもらえるとありがたい
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
createGenericAgentCoreRuntime: falseonce, deploy again withcreateGenericAgentCoreRuntime: trueChecklist
npm run cdk:testand if there are snapshot differences, executenpm run cdk:test:update-snapshotto update snapshots